Author Topic: MadShaders 0.3.0 - Dolphin scenario  (Read 4215 times)



0 Members and 1 Guest are viewing this topic.

jakub.moskal

  • Newbie
  • *
  • Posts: 1
    • View Profile
MadShaders 0.3.0 - Dolphin scenario
« on: June 20, 2014, 11:29:01 AM »
Hi,
I think there is a little bug in the dolphin_gl2.xml shader.

In the 'doLighting' function there is a line with 'spe/glossy' -> 'col += 0.25*glossy*pow(spe/glossy,8.0)*vec3(1.3,1.0,0.8)*sha*(0.3+0.7*fre)*occ;'.
When dolphin is under water, 'glossy' and 'spe' equals zero. According to specification it can produce an unspecified value.

On Intel OpenGL driver it causes a corruption - part of the dolphin body which is under water has black color.

Easy fix would be clamping the result of this division.

Could you take a closer look at that?

« Last Edit: June 20, 2014, 11:37:46 AM by jakub.moskal »

JeGX

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1320
    • View Profile
    • Geeks3D.com
Re: MadShaders 0.3.0 - Dolphin scenario
« Reply #1 on: June 20, 2014, 09:04:06 PM »
Thanks, I will look at a fix for the next release of MadShaders.